-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commands): add clear_registers command #4408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this being a new command, I think this should be implemented as a special key in the on_next_key
callback of select_register
. So you would clear registers by pressing "
and then the key to clear all registers. I'm not sure what the keybind should be though
Perhaps using |
This could get tricky on different keyboard layouts - for example mine has it on opposite sides of keyboard. It could work if this key mapping was overridable - but for that one still needs a separate command to be called. |
Another possible approach would be to create Simply binding one key to command after key |
@the-mikedavis @geometryolife Thank you for all suggestions, I implemented a solution. I'd be thankful for the review since I am still not sure about the keymapping. |
The work has been moved to #5695; this PR's source branch is master, which isn't convenient. |
Hi,
there has been a feature request for an option to delete registers, so I politely created this. Thank you for your review.
Closes #4256