Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #442 #446

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Fix #442 #446

merged 3 commits into from
Jul 15, 2021

Conversation

kirawi
Copy link
Member

@kirawi kirawi commented Jul 14, 2021

Before, the function incorrectly returned Document::default() if the path did not exist instead of simply creating an empty Rope and proceeding with the rest of the function.

Closes #442

@kirawi
Copy link
Member Author

kirawi commented Jul 15, 2021

Oh, I forgot something!

@kirawi kirawi force-pushed the fix-doc-open branch 2 times, most recently from 16e4292 to 9976a7d Compare July 15, 2021 00:55
@archseer archseer merged commit 0b1ed86 into helix-editor:master Jul 15, 2021
@kirawi kirawi deleted the fix-doc-open branch July 15, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

had issue when open a new file
2 participants