Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

had issue when open a new file #442

Closed
kabirz opened this issue Jul 14, 2021 · 4 comments · Fixed by #446
Closed

had issue when open a new file #442

kabirz opened this issue Jul 14, 2021 · 4 comments · Fixed by #446
Labels
C-enhancement Category: Improvements

Comments

@kabirz
Copy link
Contributor

kabirz commented Jul 14, 2021

lsp and language grammar not work when open a new file, and save it, show cannot write a buffer without a filename

@archseer
Copy link
Member

:w filename.txt

@kabirz
Copy link
Contributor Author

kabirz commented Jul 14, 2021

dose it mean edit a new file must like this:

touch file.txt
hx file.txt

or

hx
:w file.txt

hx

@pickfire pickfire added the C-enhancement Category: Improvements label Jul 14, 2021
@pickfire
Copy link
Contributor

pickfire commented Jul 14, 2021

Yeah, I think we should keep the filename when hx new-file. I am working on the file path with row col so maybe I can fix this in the meantime.

@kabirz
Copy link
Contributor Author

kabirz commented Jul 14, 2021

maybe #228 causes it. Previous is good.

kirawi added a commit to kirawi/helix that referenced this issue Jul 14, 2021
kirawi added a commit to kirawi/helix that referenced this issue Jul 14, 2021
@kirawi kirawi mentioned this issue Jul 14, 2021
archseer pushed a commit that referenced this issue Jul 15, 2021
* fix #442

fix #442

fmt

* create Rope from default line ending

* Fix use of encoding in Document::open()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants