Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add language ron #1925

Merged
merged 3 commits into from
Apr 5, 2022
Merged

add language ron #1925

merged 3 commits into from
Apr 5, 2022

Conversation

VuiMuich
Copy link
Contributor

@VuiMuich VuiMuich commented Apr 2, 2022

This adds language support for 'ron' as suggested in matrix chat by using the rust grammar and queries.
According to @the-M̀ikedavis there is a bug preventing the rust queries to be used direktly, therefore I symlinked runtime/queries/ron to ./rust as workaround. Not sure though, if this also works on windows.

@archseer archseer requested a review from the-mikedavis April 2, 2022 08:08
@the-mikedavis
Copy link
Member

Actually I forgot about the inherits feature for queries. Instead of symlinking, let's use a file that just says

; inherits: rust

for runtime/queries/ron/highlights.scm plus the same for the injections.scm and indents.scm.

To clear up the CI, you'll need to run cargo xtask docgen and commit the changes.

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@the-mikedavis the-mikedavis merged commit eb84d94 into helix-editor:master Apr 5, 2022
@VuiMuich VuiMuich deleted the language-ron branch April 5, 2022 15:00
@VuiMuich
Copy link
Contributor Author

VuiMuich commented Apr 5, 2022

Thanks for all the hints, I merely put the pieces of this jigsaw 🧩 together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants