-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add languages r
and rmarkdown
#1998
Conversation
Let's just leave it for now Does the user need to install the package manually? |
Yep, the command is: R -e 'install.packages("languageserver")' Is there somewhere that should be documented? |
No, if the user use the language chances are they will know, unless it requires special setup then maybe you might want to note it. |
Ok, sounds good. That's all the setup that's required. |
For the installation docs, there's a new wiki for that here if you wouldn't mind adding in a section for R. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thanks
Done!
Thanks! |
A few notes:
{r}
code blocks but should only be enabled inrmd
/Rmd
files.And two questions:
R
is an interpreted language, but I've never seen someone use a shebang in an R file. Any opinion on whether I should leave it or remove it?lang-support.md
file appears to use the name of the language server command for the default language server column. However, the name of the command for the language server in use here (this one, it's the only one I'm aware of) is just theR
interpreter itself, and the arguments instruct it to invoke thelanguageserver
package. Do we want to add in a workaround for this kind of situation so we can name thelanguageserver
package specifically, or should we just leave it?