Add gateway_info_v2, gateway_info_stream_req_v2, gateway_metadata_v2 #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffgrunewald
approved these changes
Nov 25, 2024
| @@ -43,6 +43,13 @@ message cbrs_radio_deployment_info { | |||
| } | |||
|
|
|||
| message gateway_metadata { | |||
| option deprecated = true; | |||
There was a problem hiding this comment.
i've only ever tried to deprecate fields with this notation, not entire messages but in those cases rust/prost seems to be unable to handle the message being deprecated and omitted without throwing missing field warnings. hopefully it's easier when the whole message is flagged
There was a problem hiding this comment.
Honestly, I’ve never thought about how Rust/Prost handles this deprecation, but I didn’t see any related warnings while working on this PR.
michaeldjeffrey
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since changes in gateway info response (#429, #430) breaks backward compatibility (due to signing message from server side and verifying on client):