Add deployment info to gateway_metadata #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurotych
force-pushed
the
deployment-info
branch
4 times, most recently
from
bc992aa to
3040d0e
Compare
kurotych
force-pushed
the
deployment-info
branch
from
3040d0e to
730e1db
Compare
madninja
reviewed
Nov 18, 2024
src/service/mobile_config.proto
Outdated
| repeated radio_deployment_info radio_deployment_info = 1; | ||
| } | ||
|
|
||
| message radio_deployment_info { |
kurotych
requested review from
bbalser,
jeffgrunewald,
andymck and
michaeldjeffrey
jeffgrunewald
approved these changes
Nov 19, 2024
andymck
reviewed
Nov 19, 2024
| // antenna id | ||
| uint32 antenna = 1; | ||
| // The height of the hotspot above ground level in whole meters | ||
| uint32 elevation = 2; |
There was a problem hiding this comment.
maybe add comments for each field here providing some context of each field
There was a problem hiding this comment.
I was thinking about that but nothing comes to mind except obvious: "Antenna azimuth" (etc)
andymck
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.