Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module-info parsing #7156

Merged
merged 4 commits into from
Jul 10, 2023
Merged

module-info parsing #7156

merged 4 commits into from
Jul 10, 2023

Conversation

trentjeff
Copy link
Member

  1. Makes the parsing best effort (i.e., will not fail the pico anno processor, etc.).
  2. Handles opens - fixes issue 4.x: Pico Module info parser fails on opens #7081
  3. Handles redundant uses - fixes issue 4.x: Pico generated module-info.java has redundant uses #6631

@trentjeff trentjeff self-assigned this Jul 6, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 6, 2023
@trentjeff trentjeff added the 4.x Version 4.x label Jul 6, 2023
@trentjeff trentjeff added this to the 4.0.0-M1 milestone Jul 6, 2023
@trentjeff trentjeff requested a review from tomas-langer July 6, 2023 17:09
@trentjeff trentjeff added the declarative Helidon Declarative label Jul 7, 2023
@trentjeff trentjeff mentioned this pull request Jul 7, 2023
Closed
@trentjeff trentjeff merged commit 29ccecc into helidon-io:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@trentjeff trentjeff

Labels
4.x Version 4.x declarative Helidon Declarative OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
4.0.0-M1
Development

Successfully merging this pull request may close these issues.
2 participants
@trentjeff @tomas-langer