Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: Pico Module info parser fails on opens #7081

Closed
tomas-langer opened this issue Jun 23, 2023 · 0 comments
Closed

4.x: Pico Module info parser fails on opens #7081

tomas-langer opened this issue Jun 23, 2023 · 0 comments
Assignees
@trentjeff
Labels
4.x Version 4.x bug Something isn't working declarative Helidon Declarative team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon
Milestone
4.0.0-M2

Comments

@tomas-langer
Copy link
Member

  1. we should support opens, such as in helidon-config module-info.java
  2. even if there is something in the module-info.java that the ModuleInfoDescriptorSupport does not understand, it should not fail the build

I have done a temporary fix in #7080 that skips opens directive
@tomas-langer tomas-langer added 4.x Version 4.x declarative Helidon Declarative bug Something isn't working team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon labels Jun 23, 2023
@m0mus m0mus added this to the 4.0.0-M2 milestone Jun 26, 2023
@tomas-langer tomas-langer mentioned this issue Jun 29, 2023
Merged
@trentjeff trentjeff self-assigned this Jul 6, 2023
trentjeff added a commit to trentjeff/helidon that referenced this issue Jul 6, 2023
@trentjeff
fix for issue helidon-io#7081
bd8fcf1
@trentjeff trentjeff mentioned this issue Jul 6, 2023
Merged
trentjeff added a commit that referenced this issue Jul 10, 2023
@trentjeff
module-info parsing (#7156)
29ccecc 
* fix for issue #7081
* fix for issue #6631
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentjeff trentjeff

Labels
4.x Version 4.x bug Something isn't working declarative Helidon Declarative team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon
Projects
Backlog
Archived in project
Milestone
4.0.0-M2
Development

No branches or pull requests
3 participants
@m0mus @tomas-langer @trentjeff