Fix OpenAPI UI options processing #6110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5998
Changes:
OpenApiUiFull.Builder#convertOptions
method (now renamed touiOptions
) prematurely exited a loop when processing UI options.OpenApiUiFull.Builder
kept its ownMap<Options, String>
. It now reuses theMap<String, String>
kept by its abstract superclassOpenApiUIBase.Builder
to avoid confusion and converts when needed. The change in the type of the key in the map also involves two slight changes in retrieving theurl
entry from the map for a sanity check warning.OpenApiUiFull
.Signed-off-by: [email protected] [email protected]