Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenAPI UI options processing #6110

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Feb 7, 2023

Resolves #5998

Changes:

  1. The original OpenApiUiFull.Builder#convertOptions method (now renamed to uiOptions) prematurely exited a loop when processing UI options.
  2. Originally OpenApiUiFull.Builder kept its own Map<Options, String>. It now reuses the Map<String, String> kept by its abstract superclass OpenApiUIBase.Builder to avoid confusion and converts when needed. The change in the type of the key in the map also involves two slight changes in retrieving the url entry from the map for a sanity check warning.
  3. There was redundant and confusing config logic in the abstract builder superclass and the builder in OpenApiUiFull.
  4. Expand the UI config test to make sure multiple overridden values are applied correctly.

Signed-off-by: [email protected] [email protected]

@tjquinno tjquinno requested a review from spericas February 7, 2023 18:02
@tjquinno tjquinno self-assigned this Feb 7, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 7, 2023
@tjquinno tjquinno merged commit 12c000c into helidon-io:helidon-3.x Feb 9, 2023
@tjquinno tjquinno deleted the ui-config-3.x branch February 9, 2023 06:14
@sullis sullis mentioned this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one openapi.ui.options setting takes effect
2 participants