Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x OpenAPI UI integration uses only the first pass-through property to the UI #7476

Closed
tjquinno opened this issue Aug 27, 2023 · 1 comment
Assignees
Labels
3.x Issues for 3.x version branch bug Something isn't working duplicate This issue or pull request already exists integration open-api team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon

Comments

@tjquinno
Copy link
Member

Environment Details

  • Helidon Version: 3.x
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

The OpenAPI UI integration lets users configure additional properties that have meaning to the UI itself--not to Helidon's integration--and Helidon should pass those through.

But it only passes the first property through, ignoring others.

Thanks to an internal user who looked into the code, it looks as if OpenApiUiFull#convertOptions contains a break nextKey; that should be a continue nextKey;.

Steps to reproduce

Add multiple configuration settings to be passed through to the UI. Only one goes through.

@tjquinno tjquinno added bug Something isn't working open-api 3.x Issues for 3.x version branch integration labels Aug 27, 2023
@tjquinno tjquinno added this to the 3.2.3 milestone Aug 31, 2023
@tjquinno tjquinno added the team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon label Aug 31, 2023
@tjquinno tjquinno removed this from the 3.2.3 milestone Sep 6, 2023
@tjquinno
Copy link
Member Author

tjquinno commented Sep 6, 2023

Looks like a dup of #6110

@tjquinno tjquinno closed this as completed Sep 6, 2023
@tjquinno tjquinno self-assigned this Sep 6, 2023
@tjquinno tjquinno added the duplicate This issue or pull request already exists label Sep 6, 2023
@tjquinno tjquinno changed the title OpenAPI UI integration uses only the first pass-through property to the UI 3.x OpenAPI UI integration uses only the first pass-through property to the UI Sep 7, 2023
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch bug Something isn't working duplicate This issue or pull request already exists integration open-api team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon
Projects
Archived in project
Development

No branches or pull requests

1 participant