Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive Media Common deprecated cleanup #6098

Conversation

romain-grecourt
Copy link
Contributor

  • Remove ContentWriters methods that are deprecated in 3.x
  • Aligned test method names in ContentWriterTests and ContentReaderTests
  • Removed unused private code in MessageBodyWriterContext and MessageBodyReadableContent
  • Convert private inner classes to records

Fixes #4364

- Remove the following methods in ContentWriters that are deprecated in 3.x:
    - byteArrayWriter
    - charSequenceWriter
    - charBufferWriter
    - byteChannelWriter (updated PathBodyWriter and FileBodyWriter to remove usage)
- Updated ContentWriterTests and ContentReaderTests: consistent test method names (e.g. charSequenceWriter -> writeCharSequence)
- Removed unused private code in MessageBodyWriterContext and MessageBodyReadableContent

Fixes helidon-io#4364
@romain-grecourt romain-grecourt self-assigned this Feb 7, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 7, 2023
@romain-grecourt romain-grecourt linked an issue Feb 7, 2023 that may be closed by this pull request
3 tasks
@romain-grecourt romain-grecourt merged commit 4265479 into helidon-io:main Feb 7, 2023
@romain-grecourt romain-grecourt deleted the reactive-media-common-deprecated-cleanup branch February 7, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecations: Media Common
2 participants