Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecations: Media Common #4364

Closed
3 tasks done
Tracked by #4362
tomas-langer opened this issue Jun 9, 2022 · 0 comments · Fixed by #6098
Closed
3 tasks done
Tracked by #4362

Deprecations: Media Common #4364

tomas-langer opened this issue Jun 9, 2022 · 0 comments · Fixed by #6098
Assignees
@romain-grecourt
Labels
4.x Version 4.x api-change defer media-support Media type processing in SE
Milestone
4.0.0

Comments

@tomas-langer
Copy link
Member

tomas-langer commented Jun 9, 2022 •
edited by romain-grecourt
Loading

  • ContentReaders - Methods with alternatives (since 2.0)
  • ContentTypeCharset - Class with alternative (since 2.0)
  • ContentWriters - Methods with alternatives (since 2.0)
  • MessageBodyReaderContext - Methods with alternatives (since 2.0)
  • MessageBodyWriterContext - Methods with alternatives (since 2.0)
  • ReadableByteChannelPublisher - Class with alternative (since 2.0)

Tasks:

  • remove the deprecated code
  • make sure the deprecation is correctly documented in 2.x (since, forRemoval on @deprecated annotation, use @deprecated javadoc tag to link to the correct new implementation, or describe what to do if a simple replacement does not exist)
  • validate documentation and examples are correct with regard to the deprecated element
@tomas-langer tomas-langer mentioned this issue Jun 9, 2022
Closed
13 tasks
@tomas-langer tomas-langer changed the title Media Common: multiple classes Deprecations: Media Common Jun 9, 2022
@tomas-langer tomas-langer added api-change media-support Media type processing in SE labels Jun 9, 2022
@tomas-langer tomas-langer added this to the 3.0.0 milestone Jun 9, 2022
@romain-grecourt romain-grecourt self-assigned this Jun 14, 2022
@spericas spericas removed their assignment Jun 15, 2022
@m0mus m0mus modified the milestones: 3.0.0, 4.0.0 Jul 8, 2022
@barchetta barchetta added the 4.x Version 4.x label Sep 23, 2022
@barchetta barchetta mentioned this issue Jan 18, 2023
Closed
romain-grecourt added a commit to romain-grecourt/helidon that referenced this issue Feb 7, 2023
@romain-grecourt
Reactive Media Common deprecated cleanup.
493b6c9 
- Remove the following methods in ContentWriters that are deprecated in 3.x:
    - byteArrayWriter
    - charSequenceWriter
    - charBufferWriter
    - byteChannelWriter (updated PathBodyWriter and FileBodyWriter to remove usage)
- Updated ContentWriterTests and ContentReaderTests: consistent test method names (e.g. charSequenceWriter -> writeCharSequence)
- Removed unused private code in MessageBodyWriterContext and MessageBodyReadableContent

Fixes helidon-io#4364
@romain-grecourt romain-grecourt mentioned this issue Feb 7, 2023
Merged
@romain-grecourt romain-grecourt linked a pull request Feb 7, 2023 that will close this issue
Reactive Media Common deprecated cleanup #6098
Merged
romain-grecourt added a commit that referenced this issue Feb 7, 2023
@romain-grecourt
Reactive Media Common deprecated cleanup. (#6098)
4265479 
- Remove the following methods in ContentWriters that are deprecated in 3.x:
    - byteArrayWriter
    - charSequenceWriter
    - charBufferWriter
    - byteChannelWriter (updated PathBodyWriter and FileBodyWriter to remove usage)
- Updated ContentWriterTests and ContentReaderTests: consistent test method names (e.g. charSequenceWriter -> writeCharSequence)
- Removed unused private code in MessageBodyWriterContext and MessageBodyReadableContent

Fixes #4364
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romain-grecourt romain-grecourt

Labels
4.x Version 4.x api-change defer media-support Media type processing in SE
Projects
Backlog
Archived in project
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Reactive Media Common deprecated cleanup romain-grecourt/helidon
5 participants
@romain-grecourt @spericas @barchetta @m0mus @tomas-langer