Fix Move one Beat left button #601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses helge17#585 . Original issue: When moving to the left, the `theMove` parameter is negative, and would go down the path of removing beats. With this, we would end up removing the beats that had the notes and would not re-add them. Fix: Adds a hash-map of <time after move, list of notes pre-move> so we can keep track of what notes need to be moved, and add them to the new (post-move) beats.
|
I just performed a few tests, it does not solve the issue in all cases, see video moveLeft.mp4 |
guiv42
reviewed
Dec 15, 2024
Thanks for catching that! I was blindly copying the notes from the deleted beat's voices to the new beat voices. This didn't take the new voice's duration into consideration. Since the duration wasn't taken into account, any note that has a longer duration than was already on the beat would get discarded. It also had the side effect of other beat metadata being removed (chord, text event, etc.). I will try to address this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #585 .
Original issue: When moving to the left, the
theMoveparameter is negative, and would go down the path of removing beats. With this, we would end up removing the beats that had the notes and would not re-add them.Fix: Adds a hash-map of <time after move, list of notes pre-move> so we can keep track of what notes need to be moved, and add them to the new (post-move) beats.