Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move one beat left does not work #585

Open
guiv42 opened this issue Nov 27, 2024 · 1 comment
Open

move one beat left does not work #585

guiv42 opened this issue Nov 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@guiv42
Copy link
Collaborator

guiv42 commented Nov 27, 2024

configuration: TuxGuitar 1.6.4, Linux openSuse tumbleweed
bug is reproduced with TuxGuitar 1.5.6

video (1.5.6) is self-explanatory

moveOneBeatLeft.mp4
@guiv42 guiv42 added the bug Something isn't working label Nov 27, 2024
ffio1 added a commit to ffio1/tuxguitar that referenced this issue Dec 15, 2024
@ffio1
Fix Move one Beat left button
36d7aa0 
Addresses helge17#585 .

Original issue: When moving to the left, the `theMove` parameter is negative, and would go down the path of removing beats. With this, we would end up removing the beats that had the notes and would not re-add them.

Fix: Adds a hash-map of <time after move, list of notes pre-move> so we can keep track of what notes need to be moved, and add them to the new (post-move) beats.
@ffio1 ffio1 mentioned this issue Dec 15, 2024
Open
@ffio1
Copy link
Contributor

ffio1 commented Dec 15, 2024

Proposed fix sent in PR #601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ffio1 @guiv42