Build tree from values instead of wrapping and unwrapping #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobstanley
reviewed
Mar 4, 2021
moodmosaic
reviewed
Mar 4, 2021
There was a problem hiding this comment.
Great work! See @jacobstanley's comment and the one I also left. I'd be nice to have this PR on this release.
Closed
HuwCampbell
force-pushed
the
topic/tidy-tree-search
branch
from
ab25a56 to
fcd47fe
Compare
jacobstanley
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor cleanup, there should be no function differences.
As I mentioned earlier, my original version wrapped and unwrapped trees a bit much, making the code a bit harder to follow.
Pulling out a helper for
integral_means we can build on values only.