Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GHC 9.0.1 #416

Closed
sjakobi opened this issue Feb 27, 2021 · 11 comments · Fixed by #417
Closed

Support for GHC 9.0.1 #416

sjakobi opened this issue Feb 27, 2021 · 11 comments · Fixed by #417

Comments

@sjakobi
Copy link
Contributor

sjakobi commented Feb 27, 2021

Building with --allow-newer currently results in a build failure. This patch should help: https://gitlab.haskell.org/ghc/head.hackage/-/blob/ea1b6b35e46870fea5a9596fcac8df0b9cd105bd/patches/hedgehog-1.0.4.patch

@amesgen
Copy link

amesgen commented Feb 27, 2021

It builds fine on master with GHC 9.0.1, I think it only needs a release.

@moodmosaic
Copy link
Member

Yep, planning for a release this week.

@moodmosaic
Copy link
Member

@sjakobi, thank you for opening this! Should we close this in favor of #392?

@sjakobi
Copy link
Contributor Author

sjakobi commented Mar 2, 2021

@moodmosaic Feel free to close. I'd love to get a ping once you've uploaded a compatible release though! :)

@moodmosaic
Copy link
Member

Sure! Let's close it once the release is out, hopefully this week.

@moodmosaic
Copy link
Member

@sjakobi, we'll do the release once we merge #414 and #415 by @HuwCampbell. Hope that's not blocking you. If it does, please let us know.

@HuwCampbell
Copy link
Member

I'll fix these up today.

@vrom911
Copy link
Contributor

vrom911 commented Mar 11, 2021

Thanks a lot for working on this, everyone!

@moodmosaic seems like both of the mentioned PRs are merged now. Do you have any estimates on the releasing? And do you probably need any extra help in order to speed up this one? 🙂

@moodmosaic
Copy link
Member

Unfortunately I got sick 😥 so it might take a few days more, unless @jacobstanley can do it today or tomorrow.

@sjakobi
Copy link
Contributor Author

sjakobi commented Mar 11, 2021

Get well soon, @moodmosaic! :) FWIW, my need for a compatible hedgehog release is not particularly urgent.

@vrom911
Copy link
Contributor

vrom911 commented Mar 11, 2021

Get well soon, @moodmosaic ! No worries, this could, of course, wait. Take care of yourself first 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants