Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error: use of unstable library feature 'renamed_spin_loop' #60

Closed
taeh98 opened this issue Aug 2, 2021 · 4 comments · Fixed by #61 or #63
Closed

Build error: use of unstable library feature 'renamed_spin_loop' #60

taeh98 opened this issue Aug 2, 2021 · 4 comments · Fixed by #61 or #63

Comments

@taeh98
Copy link

taeh98 commented Aug 2, 2021

Hello,

I am getting a build error when using sharded-slab v0.1.2. It was caused by "hint::spin_loop()" on line 909 in src/page/slot.rs. The error was:

error[E0658]: use of unstable library feature 'renamed_spin_loop'
--> ...../sharded-slab-0.1.2/src/page/slot.rs:909:9

note: see issue #55002 rust-lang/rust#55002 for more information

error: aborting due to previous error

Please could you fix the cause of this error, or let me know if you think this was caused by a mistake on my end? Thank you!

Environment info:

rustup unchanged - 1.24.3
info: latest update on 2021-07-29, rust version 1.54.0 (a178d0322 2021-07-26)

@Darksonn
Copy link

Darksonn commented Aug 2, 2021

I ran in to this as well. In our case the fix appears to be to update the Rust version.

@djc
Copy link
Contributor

djc commented Aug 2, 2021

I'm also running into this issue with Quinn's CI, which has 1.47 as the MSRV. According to the docs std::hint::spin_loop() was stabilized for Rust 1.49, so I don't see how the OP could have run into this issue with 1.54 (it seems to work with me with 1.54 on my local machine). I don't see any mention of a MSRV in the README or CI definition for this project; however, given that this is used in tracing and tracing still tests for 1.42, I suppose this was a mistake?

This was referenced Aug 2, 2021
@hawkw hawkw closed this as completed in #61 Aug 2, 2021
hawkw pushed a commit that referenced this issue Aug 2, 2021
* Use deprecated `std::atomic::spin_loop_hint()` to support older Rust

* Match tracing MSRV in CI

Fixes #60.
hawkw added a commit that referenced this issue Aug 2, 2021
### v0.1.3 (2021-08-02)

#### Bug Fixes

*   set up MSRV in CI (#61) ([dfcc908](dfcc908), closes [#60](#60))
@hawkw
Copy link
Owner

hawkw commented Aug 2, 2021

Thanks, sorry about that --- I wasn't thinking when I was trying to fix the deprecation warning yesterday. Getting ready to release 0.1.3 to fix the MSRV build.

hawkw added a commit that referenced this issue Aug 2, 2021
### v0.1.3 (2021-08-02)

#### Bug Fixes

*   set up MSRV in CI (#61) ([dfcc908](dfcc908), closes [#60](#60))
hawkw added a commit that referenced this issue Aug 2, 2021
#### Bug Fixes

*   set up MSRV in CI (#61) ([dfcc908](dfcc908), closes [#60](#60))
* **tests:**  duplicate `hint` mod defs with loom ([0ce3fd9](0ce3fd9))
@hawkw
Copy link
Owner

hawkw commented Aug 2, 2021

Okay, I've published v0.1.3 and yanked v0.1.2. Again, sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants