Gitlab CI improvements #3324
Merged
Gitlab CI improvements #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
requested review from
berberman,
michaelpj,
guibou and
hasufell
as code owners
michaelpj
reviewed
Nov 8, 2022
| @@ -0,0 +1,34 @@ | |||
| { system }: | |||
There was a problem hiding this comment.
what is this for? what does it do? etc. etc. documentation please!
There was a problem hiding this comment.
This is taken almost verbatim from the GHC nix setup script. I can add a note pointing to that, but beyond that I have very little experience with nix, so all of the nix stuff is just cargo-culted from GHC itself.
There was a problem hiding this comment.
"I cargo-culted this from GHC, here's a link to the upstream version" is incredibly useful information for someone reading this!
|
Looks ok to me... but I won't be touching anything nix related. So hope you're up for maintaining that. |
|
@wz1000 do you still need a stamp on this? |
michaelpj
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the release scripts in a number of ways and unblocks
releases on darwin due to LLVM mismatches.