Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate release CI to github #3406

Merged
merged 16 commits into from
Mar 23, 2023
Merged

Migrate release CI to github #3406

merged 16 commits into from
Mar 23, 2023

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Dec 16, 2022 •
edited
Loading

TODO:

  • add tests
  • Cirrus CI works
  • darwin M1 works
  • Linux aarch64 works
  • Alpine builds work
  • check stripping on darwin
  • re-add deleted workflows (for convenience of testing)
  • disable pipeline on push etc
  • add script to download artifacts
  • add src tarball in release job
  • fix HLS-1.9.1.0 with GHC-9.4.4 is broken on "Unknown Linux" #3497

@hasufell
Copy link
Member Author

Fixes #3398

@michaelpj
Copy link
Collaborator

ping us when you want review, not clear if you want that yet?

@hasufell hasufell marked this pull request as draft December 16, 2022 10:43
@hasufell
Copy link
Member Author

@michaelpj it's a draft, but there won't be major changes (except adding the tests)... now it's bug-hunting, which will take quite a while

@hasufell hasufell force-pushed the github-ci branch 2 times, most recently from 4b64d6f to ba090b8 Compare December 17, 2022 05:07
@hasufell hasufell marked this pull request as ready for review December 17, 2022 05:10
@hasufell hasufell force-pushed the github-ci branch 21 times, most recently from 342eb26 to abb0226 Compare December 18, 2022 09:52
@hasufell hasufell force-pushed the github-ci branch 3 times, most recently from 6ed4f10 to 475e35f Compare March 4, 2023 06:59
@hasufell hasufell force-pushed the github-ci branch 2 times, most recently from d89703a to 8da8776 Compare March 4, 2023 12:45
@hasufell hasufell force-pushed the github-ci branch 2 times, most recently from cdf9dc2 to 34fe456 Compare March 5, 2023 15:34
@wz1000
Copy link
Collaborator

wz1000 commented Mar 22, 2023

Let's merge this @michaelpj @hasufell. I am broadly OK with these changes and they were used to produce the 1.9.1.0 release which seems to have gone smoothly.

@hasufell
Copy link
Member Author

Yes, we can iterate on code deduplication later.

@wz1000 wz1000 added the merge me Label to trigger pull request merge label Mar 23, 2023
@wz1000 wz1000 dismissed fendor’s stale review March 23, 2023 11:22

future work

@mergify mergify bot merged commit 9fe56f1 into master Mar 23, 2023
@michaelpj
Copy link
Collaborator

👍

@wz1000 wz1000 mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj left review comments

@wz1000 wz1000 wz1000 approved these changes

@Anton-Latukha Anton-Latukha Awaiting requested review from Anton-Latukha

@Ailrun Ailrun Awaiting requested review from Ailrun

@fendor fendor Awaiting requested review from fendor fendor is a code owner

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hasufell @michaelpj @fendor @wz1000