Improve memory characteristics of ExportsMap #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
requested review from
jneira,
berberman and
pepeiborra
as code owners
wz1000
force-pushed
the
wip/exports-map-mem
branch
from
da753af to
795dfa5
Compare
wz1000
commented
Sep 28, 2022
| mText = pack $ moduleNameString mn | ||
| fmap (wrap . unwrap mText) <$> withHieDb (\hieDb -> getExportsForModule hieDb mn) | ||
| let exportsMap = Map.fromListWith (<>) (concat idents) | ||
| return $ ExportsMap exportsMap $ buildModuleExportMap (concat idents) |
There was a problem hiding this comment.
This fixes a bug where the module exports map created from hiedb would be keyed by the identifier name instead of the module name. Caught because of using proper types instead of Text!
pepeiborra
approved these changes
Sep 30, 2022
wz1000
force-pushed
the
wip/exports-map-mem
branch
from
6a6493c to
a4fe2bf
Compare
wz1000
force-pushed
the
wip/exports-map-mem
branch
4 times, most recently
from
e5cb905 to
c13ef89
Compare
wz1000
force-pushed
the
wip/exports-map-mem
branch
4 times, most recently
from
4044636 to
7e64746
Compare
wz1000
force-pushed
the
wip/exports-map-mem
branch
2 times, most recently
from
c9c3181 to
b7896be
Compare
wz1000
force-pushed
the
wip/exports-map-mem
branch
from
b7896be to
4ca97e2
Compare
Storing rendered names as `Text`, especially for parents, adds a lot of duplication to the ExportsMap. Instead we store the `OccName`s directly, which have hash-consed symbols due stored as `FastStrings` and render it out on demand (which is just decoding the UTF-8 FastString to UTF-16 text for text <2.0, and essentially free on text >2.0).
wz1000
force-pushed
the
wip/exports-map-mem
branch
from
4ca97e2 to
996c62a
Compare
wz1000
force-pushed
the
wip/exports-map-mem
branch
from
996c62a to
7a4e1a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing rendered names as
Text, especially for parents, adds a lot of duplication to the ExportsMap.Instead we store the
OccNames directly, which have hash-consed symbols due stored asFastStringsand render it out on demand (which is just decoding the UTF-8 FastString to UTF-16 text for text <2.0,
and essentially free on text >2.0).
This PR depends on #3204, ignore that commit while reviewing.