Fix typo in changelog #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
We already normalise filepaths in NormalizedFilePath. haskell-lsp changed things such that the conversion from Uri to NormalizedUri normalises the filepath again which caused a significant slowdown in GetFileExists. We already have a wrapper for converting from NormalizedFilePath to NormalizedUri so this PR changes this wrapper to inline the definition without the additional layer of normalisation. fixes #298
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
I accidentally broke this on Windows in #303 by letting the two conversirons get out of sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admittedly 'Forourmolu' is probably no sillier than the current name...