Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GHC-8.10.2 #298

Closed
mouse07410 opened this issue Aug 8, 2020 · 1 comment · Fixed by #308
Closed

Support for GHC-8.10.2 #298

mouse07410 opened this issue Aug 8, 2020 · 1 comment · Fixed by #308
Labels
type: enhancement New feature or request

Comments

@mouse07410
Copy link

GHC-8.10.2 was just released.

Hopefully, the differences between it and GHC-8.10.1 from the HLS point of view are minor enough to make adding the support easy?

@Ailrun Ailrun added the type: enhancement New feature or request label Aug 9, 2020
@mouse07410
Copy link
Author

mouse07410 commented Aug 9, 2020

To illustrate better (master branch, haven't gotten around to hls-3 yet):

$ ./cabal-hls-install ghcs
Resolving dependencies...
Build profile: -w ghc-8.10.1 -O1
In order, the following will be built (use -v for more details):
 - fake-package-0 (exe:script) (configuration changed)
Configuring executable 'script' for fake-package-0..
Preprocessing executable 'script' for fake-package-0..
Building executable 'script' for fake-package-0..
[1 of 1] Compiling Main             ( Main.hs, /Users/ur20980/src/haskell-language-server/dist-newstyle/build/x86_64-osx/ghc-8.10.1/fake-package-0/x/script/build/script/script-tmp/Main.dyn_o )

Main.hs:20:1: warning: [-Wmissing-signatures]
    Top-level binding with no type signature: main :: IO ()
   |
20 | main = defaultMain
   | ^^^^
Linking /Users/ur20980/src/haskell-language-server/dist-newstyle/build/x86_64-osx/ghc-8.10.1/fake-package-0/x/script/build/script/script ...

********************************************************************************
Found the following GHC paths: 
ghc-8.10.1: /Users/ur20980/.ghcup/bin/ghc-8.10.1
ghc-8.6.5: /Users/ur20980/.ghcup/bin/ghc-8.6.5
ghc-8.8.3: /Users/ur20980/.ghcup/bin/ghc-8.8.3
ghc-8.8.4: /Users/ur20980/.ghcup/bin/ghc-8.8.4

********************************************************************************

Build completed in 0.00s

$ type ghc-8.10.2
ghc-8.10.2 is /Users/ur20980/.ghcup/bin/ghc-8.10.2
$ type ghc-8.10.1
ghc-8.10.1 is /Users/ur20980/.ghcup/bin/ghc-8.10.1
$ 

Update

And, of course, this:

$ ./cabal-hls-install hls-8.10.2
Resolving dependencies...
Build profile: -w ghc-8.10.1 -O1
In order, the following will be built (use -v for more details):
 - fake-package-0 (exe:script) (configuration changed)
Configuring executable 'script' for fake-package-0..
Preprocessing executable 'script' for fake-package-0..
Building executable 'script' for fake-package-0..
[1 of 1] Compiling Main             ( Main.hs, /Users/ur20980/src/haskell-language-server/dist-newstyle/build/x86_64-osx/ghc-8.10.1/fake-package-0/x/script/build/script/script-tmp/Main.dyn_o )

Main.hs:20:1: warning: [-Wmissing-signatures]
    Top-level binding with no type signature: main :: IO ()
   |
20 | main = defaultMain
   | ^^^^
Linking /Users/ur20980/src/haskell-language-server/dist-newstyle/build/x86_64-osx/ghc-8.10.1/fake-package-0/x/script/build/script/script ...
Error when running Shake build system:
  at want, called at src/Development/Shake/Internal/Args.hs:83:69 in shk-0.18.5-acb9f7a3:Development.Shake.Internal.Args
* Depends on: hls-8.10.2
  at error, called at src/Development/Shake/Internal/Rules/File.hs:179:58 in shk-0.18.5-acb9f7a3:Development.Shake.Internal.Rules.File
* Raised the exception:
Error, file does not exist and no rule available:
  hls-8.10.2

pepeiborra pushed a commit that referenced this issue Dec 27, 2020
We already normalise filepaths in NormalizedFilePath. haskell-lsp
changed things such that the conversion from Uri to NormalizedUri
normalises the filepath again which caused a significant slowdown in
GetFileExists.

We already have a wrapper for converting from NormalizedFilePath to
NormalizedUri so this PR changes this wrapper to inline the definition
without the additional layer of normalisation.

fixes #298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants