Remove some partial functions from Shake.hs #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
force-pushed
the
mpj/partial-functions-shake
branch
from
894126b to
06535a4
Compare
michaelpj
changed the title
michaelpj
force-pushed
the
mpj/partial-functions-shake
branch
from
06535a4 to
a4c2a74
Compare
Also removes a partial pattern match from Action.hs.
michaelpj
force-pushed
the
mpj/partial-functions-shake
branch
from
a4c2a74 to
01c090d
Compare
pepeiborra
approved these changes
Jun 24, 2022
|
Some reproducible test failures on Windows? Baffling. I'm not sure what to do with that 🤔 |
I've noticed this since #2920, it fails randomly and can be passed after some retry. |
|
Are you sure? It seems pretty repeatable. |
|
On #2960, it failed at the previous two tries, and succeed the third time. https://github.com/haskell/haskell-language-server/runs/7057233778?check_suite_focus=true But I really saw your test failed too much indeed. |
|
Okay, it happened on #2995 too, so at least it's not me. |
|
It worked mysteriously :) |
|
Displeasing :( |
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
Also removes a partial pattern match from Action.hs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes a partial pattern match from Action.hs.