Add numeric-version option for wrapper and server #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
numeric-version
branch
2 times, most recently
from
64dd393 to
fa44b4d
Compare
|
@hasufell Should the |
|
Newline or not will both work |
Ailrun
reviewed
Jul 26, 2020
Also correctly shuts down the language server if `--version` was given. Minor rework of argument parser.
lukel97
approved these changes
Jul 26, 2020
pepeiborra
pushed a commit
that referenced
this pull request
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #238
Also correctly shuts down the language server if
--versionwas given.Minor rework of argument parser.
This might cause breakage, since combinations such as
haskell-language-server --version --lspused to be valid but are not anymore. Not sure if and how important that is, though. I think we can change it if it is important, but we might lose the stronger types or increase the complexity of the arguments parser.