Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hls --version does not work #238

Closed
hasufell opened this issue Jul 26, 2020 · 2 comments · Fixed by #241
Closed

hls --version does not work #238

hasufell opened this issue Jul 26, 2020 · 2 comments · Fixed by #241
Labels
type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. type: enhancement New feature or request

Comments

@hasufell
Copy link
Member

It starts building stuff instead of reporting the version and then exiting.
@fendor
Copy link
Collaborator

fendor commented Jul 26, 2020

Indeed: https://github.com/haskell/haskell-language-server/blob/master/exe/Main.hs#L131
Looks like we are not terminating correctly

@hasufell
Copy link
Member Author

In addition, there should be a --numeric-version opts that is machine-parsable and only prints the raw version.

@hasufell hasufell mentioned this issue Jul 26, 2020
Closed
@fendor fendor mentioned this issue Jul 26, 2020
Merged
@Ailrun Ailrun added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. type: enhancement New feature or request labels Jul 26, 2020
pepeiborra pushed a commit that referenced this issue Dec 27, 2020
@jacg @cocreature
Tests for issue #237 (#238)
4e8178d 
* Add tests for issue #237

* Tell hlint to ignore test sample code

* Add test showing similar problem in listcomps

* Identify implementation necessary for test to pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add numeric-version option for wrapper and server fendor/haskell-language-server
3 participants
@hasufell @fendor @Ailrun