-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows to ghcup artifacts and generate sha256 sums #1970
Conversation
jneira
commented
Jun 23, 2021
- So the next release will generate it as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay from my side; I'm quite busy because of POPL...
Anyway, thank you very much for fixing this!
7916fc2
to
140cdcd
Compare
140cdcd
to
77f00f4
Compare
|
@maerwald the sha256 sums looks a little bit hairy with those long paths, but hashes are correct:
|
The sums file looks nicer now:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repository is currently unmaintained by a team of developers at GitHub. The repository is here and you can use it as an example, or in Actions. However please be aware that we are not going to be updating issues or pull requests on this repository. (https://github.com/actions/upload-release-asset)
It looks like actions/upload-release-asset
is obsolete, and we should use softprops/action-gh-release
to upload the assets.