clean up ghc-api pragmas #1785
Merged
clean up ghc-api pragmas #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, we don't? Then I should probably also remove all the new references to it in this PR #1649. What was it used for before and what has changed? |
We no longer depend on ghc-lib so it's cleanup time
pepeiborra
force-pushed
the
ghc-api-cleanup
branch
from
9ab0b4d to
35173dc
Compare
|
Ah, thanks! |
Ailrun
reviewed
May 2, 2021
| @@ -9,7 +9,6 @@ maintainer: [email protected] | |||
| category: Development | |||
| build-type: Simple | |||
| extra-source-files: | |||
| include/ghc-api-version.h | |||
There was a problem hiding this comment.
It looks like actual file is not deleted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer depend on ghc-lib so it's cleanup time