Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lose the ghc-lib flag #1366

Merged
merged 4 commits into from
Feb 16, 2021
Merged

Lose the ghc-lib flag #1366

merged 4 commits into from
Feb 16, 2021

Conversation

pepeiborra
Copy link
Collaborator

@cocreature confirmed that DA are not depending on this anymore and we are free to drop it.

Closes #784

@wz1000
Copy link
Collaborator

wz1000 commented Feb 14, 2021

There is a ghc-lib flag in hie-compat that can also be removed

@pepeiborra
Copy link
Collaborator Author

There is a ghc-lib flag in hie-compat that can also be removed

That doesn't seem a huge priority since hie-compat is relatively stable

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Feb 14, 2021
@pepeiborra pepeiborra force-pushed the drop-ghclib-flag branch 2 times, most recently from 74ae2b7 to 396d5d4 Compare February 15, 2021 19:31
@mergify mergify bot merged commit f73b936 into master Feb 16, 2021
@pepeiborra pepeiborra mentioned this pull request May 2, 2021
Merged
@michaelpj michaelpj mentioned this pull request Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wz1000 wz1000 wz1000 approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reenable -fghc-lib build
3 participants
@pepeiborra @wz1000 @Ailrun