Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tactics tests to be standalone #1425

Merged
merged 6 commits into from
Feb 23, 2021
Merged

Move tactics tests to be standalone #1425

merged 6 commits into from
Feb 23, 2021

Conversation

isovector
Copy link
Collaborator

This PR follows the lead of 4c2011a, and moves the functional tactics tests into the hls-tactics-plugin package.

@isovector isovector requested a review from pepeiborra February 22, 2021 01:24
pepeiborra
pepeiborra approved these changes Feb 22, 2021
View reviewed changes
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@isovector isovector added the merge me Label to trigger pull request merge label Feb 22, 2021
@jneira
Copy link
Member

jneira commented Feb 22, 2021 •
edited
Loading

The unique caveat of spliting out all functional tests is we will lose testing the interaction of several plugins.
For some plugins and formatters is clear the separation and the interaction only throws false negatives but not sure if that may the case for all plugins (moreover if they change some global state)

@isovector isovector removed the merge me Label to trigger pull request merge label Feb 23, 2021
@isovector isovector added the merge me Label to trigger pull request merge label Feb 23, 2021
@mergify mergify bot merged commit cf9cbeb into haskell:master Feb 23, 2021
@jneira jneira mentioned this pull request Feb 24, 2021
Closed
@isovector isovector mentioned this pull request Feb 28, 2021
Merged
@isovector isovector deleted the tactic-tests branch March 1, 2021 20:17
@berberman berberman mentioned this pull request Mar 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isovector @jneira @pepeiborra