-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable auto extend imports and drop snippets for infix completions #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
force-pushed
the
completions
branch
2 times, most recently
from
January 27, 2021 09:06
466ec47
to
3e37ba7
Compare
pepeiborra
changed the title
Reenable auto extend imports
Reenable auto extend imports and drop snippets for infix completions
Jan 27, 2021
pepeiborra
force-pushed
the
completions
branch
from
January 27, 2021 19:57
3e37ba7
to
bd89e9f
Compare
pepeiborra
force-pushed
the
completions
branch
from
January 30, 2021 12:34
bd89e9f
to
5baf6e5
Compare
konn
reviewed
Jan 30, 2021
konn
reviewed
Jan 30, 2021
konn
reviewed
Jan 30, 2021
pepeiborra
force-pushed
the
completions
branch
from
January 30, 2021 16:04
b0e4621
to
b445ddc
Compare
konn
approved these changes
Jan 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
pepeiborra
force-pushed
the
completions
branch
4 times, most recently
from
January 31, 2021 14:48
1085142
to
cff2b03
Compare
pepeiborra
force-pushed
the
completions
branch
from
January 31, 2021 19:36
cff2b03
to
b3a94c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the work done by @gdevanla in haskell/ghcide#930 and @berberman in #1246 to reenable completions to automatically extend import lists.
There were two issues that led to this feature getting disabled:
While I was there, I also took the chance to drop snippets when typing an infix combinator