-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use exact print to extend import lists #1246
Use exact print to extend import lists #1246
Conversation
Parsed source returned by @pepeiborra Can I change the following
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, thank you so much!
…haskell-language-server into extend-import-list-exactprint
Hmm, the test suite of eval plugin failed again and again... |
@berberman with this change and a bit more work I think we can restore the work that @gdevanla did to automatically extend imports on completions. Do you or @gdevanla already plan to do it? |
I have been busy and have not caught up with many things that have happened since last month. I know @pepeiborra had to disable extending imports. I can take a look at it if @berberman has not already done any work on that. |
@pepeiborra I'm not familiar with code responsible for completions, and have not investigated yet. So please let @gdevanla do that. |
@gdevanla @berberman I was actually planning to look at it today, was just checking that no one else was already working on it. |
Rework haskell/ghcide#942
Things to do:
mkVarName
andmkTcClsName
withparseIdentifier