Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Enable all working test suites and add linux-cabal job in Azure #1571

Merged
merged 80 commits into from
Jan 15, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented Jan 12, 2020

  • Enable test-suites:
  • cabal jobs:
    • I've added one for unix, the next one will be add it for macos and windows

Make progress towards #1401
Closes #1431

@jneira
Copy link
Member Author

jneira commented Jan 13, 2020

I am afraid it takes many time to finish, what do you think about support only the last two minor versions of ghc? Or even only the last minor version. We always will have circleci with all ghcs as baseline.

@jneira jneira requested review from fendor and lukel97 January 13, 2020 05:19
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!
It looks like it is taking longer than stack builds because the cache isnt used, yet. Maybe it is not warmed-up yet?

.azure/linux-cabal.yml Show resolved Hide resolved
.azure/linux-cabal.yml Outdated Show resolved Hide resolved
.azure/linux-cabal.yml Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@jneira
Copy link
Member Author

jneira commented Jan 13, 2020

It looks like it is taking longer than stack builds because the cache isnt used, yet. Maybe it is not warmed-up yet?

I am afraid that run the jobs with test enabled and full caching takes 40 min on average (+-) so
40 jobs / 10 parallel jobs * 40 min =160 min, with all jobs running the func-test

And we want to add more cabal jobs so time will be increased.

We could only run the func-test suite for last minor versions and keep the builds and the rest of suites?

@fendor
Copy link
Collaborator

fendor commented Jan 13, 2020

I think these times are fine.

@jneira
Copy link
Member Author

jneira commented Jan 13, 2020

I think these times are fine.

Mmm well the only caveat is they make pr's heavier and somewhat less agile but if you are fine, me too 😀

@jneira jneira changed the title Enable all working test suites and add linux-cabal job in Azure [WIP] Enable all working test suites and add linux-cabal job in Azure Jan 14, 2020
@jneira
Copy link
Member Author

jneira commented Jan 14, 2020

I am trying to enable the maximum functional tests possible on windows

@jneira jneira changed the title [WIP] Enable all working test suites and add linux-cabal job in Azure Enable all working test suites and add linux-cabal job in Azure Jan 15, 2020
@jneira jneira merged commit cf025df into haskell:master Jan 15, 2020
@jneira jneira deleted the azure-cabal branch January 15, 2020 05:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make cabal a first class citizen for CI
2 participants