Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Make cabal a first class citizen for CI #1431

Closed
fendor opened this issue Oct 29, 2019 · 3 comments · Fixed by #1571
Closed

Make cabal a first class citizen for CI #1431

fendor opened this issue Oct 29, 2019 · 3 comments · Fixed by #1571
Labels
build Continuous integration and building type: enhancement Well Defined Task - Awaiting PR

Comments

@fendor
Copy link
Collaborator

fendor commented Oct 29, 2019

CI hardly uses cabal, although it is one of the two supported installation methods.
For all supported GHC Versions, we should add a CI option to build HIE with cabal.
Also, we should run the tests with cabal as well.
@fendor fendor mentioned this issue Dec 26, 2019
Merged
2 tasks
@jneira
Copy link
Member

jneira commented Jan 14, 2020

I am adding cabal jobs with tests for ghc-8.6.5 and ghc-8.4.4: #1571
@fendor It would be enough to close this or you think all supported ghcs will be needed?
or maybe it should be added to circle ci...

@fendor
Copy link
Collaborator Author

fendor commented Jan 14, 2020

Good enough for me! Tests have still a run-time dependency on stack, right?

@jneira
Copy link
Member

jneira commented Jan 14, 2020

Yeah, the CabalHelper unit tests fails if stack (or cabal) is not in path

@jneira jneira mentioned this issue Jan 14, 2020
Merged
jneira added a commit that referenced this issue Jan 15, 2020
@jneira
Enable all working test suites and add linux-cabal job in Azure (#1571)
cf025df 
* Enabled test-suites:
  * Linux, with stack or cabal, all test suites are enabled
  * Macos:
      * ghc-8.6.*: all suites enabled
      * ghc-8.4.*: func-test and dispatcher-test disabled
  * Windows
      * unit-test enabled
             * Except CabalHelper ones for ghc-8.6.4
      * func-test enabled with almost all tests
* cabal job:
   * Aadded one for linux

Make progress towards #1401
Closes #1431
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
build Continuous integration and building type: enhancement Well Defined Task - Awaiting PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable all working test suites and add linux-cabal job in Azure jneira/haskell-ide-engine
2 participants
@jneira @fendor