Remove ghc-project-types

They are only used for the GHC module graph, which is currently not generated in any useful way, so not used. Closes #1486
haskell · Dec 21, 2019 · 738a019 · 738a019
1 parent f94557b
commit 738a019
Show file tree

Hide file tree

Showing 12 changed files with 12 additions and 23 deletions.
diff --git a/cabal.project b/cabal.project
@@ -4,7 +4,6 @@ packages:
 
          -- ./submodules/HaRe
          ./submodules/cabal-helper/
-         ./submodules/ghc-mod/ghc-project-types
 
 tests: true
 

diff --git a/hie-plugin-api/Haskell/Ide/Engine/Ghc.hs b/hie-plugin-api/Haskell/Ide/Engine/Ghc.hs
@@ -11,7 +11,7 @@ module Haskell.Ide.Engine.Ghc
     setTypecheckedModule
   , Diagnostics(..)
   , AdditionalErrs
-  , cabalModuleGraphs
+  -- , cabalModuleGraphs
   , makeRevRedirMapFunc
   ) where
 
@@ -22,7 +22,7 @@ import           Control.Monad.IO.Class
 import           Control.Monad                  ( when )
 import           Data.IORef
 import qualified Data.Map.Strict                   as Map
-import qualified Data.IntMap.Strict                   as IM
+-- import qualified Data.IntMap.Strict                   as IM
 import           Data.Semigroup ((<>), Semigroup)
 import qualified Data.Set                          as Set
 import qualified Data.Text                         as T
@@ -52,10 +52,10 @@ import qualified HIE.Bios.Ghc.Load as BIOS
 
 import System.Directory
 
-import GhcProject.Types as GM
-import GhcMake ( moduleGraphNodes )
+-- import GhcMake ( moduleGraphNodes )
 import GhcMonad
 
+-- ---------------------------------------------------------------------
 
 newtype Diagnostics = Diagnostics (Map.Map NormalizedUri (Set.Set Diagnostic))
   deriving (Show, Eq)
@@ -290,6 +290,11 @@ setTypecheckedModule_load uri =
 
         return $ IdeResultOk (Diagnostics diags2,errs)
 
+{-
+
+-- TODO: Come up with a reasonable approach to generate a module graph
+-- for a given component or package.
+
 -- TODO: make this work for all components
 cabalModuleGraphs :: IdeGhcM [GM.GmModuleGraph]
 cabalModuleGraphs = do
@@ -313,6 +318,7 @@ cabalModuleGraphs = do
                                ]
                   ]
   pure [GmModuleGraph gmg]
+-}
 
 -- ---------------------------------------------------------------------
 

diff --git a/hie-plugin-api/Haskell/Ide/Engine/PluginApi.hs b/hie-plugin-api/Haskell/Ide/Engine/PluginApi.hs
@@ -28,14 +28,8 @@ setTypecheckedModule
 
 module Haskell.Ide.Engine.PluginApi
   (
-  -- ** Re-exported from ghc-mod via ghc-project-types
-    GP.GmModuleGraph(..)
-  , GP.ModulePath(..)
-  , GP.GmComponent(..)
-  , GP.GmComponentType(..)
-
   -- * IDE monads
-  , HIE.IdeState(..)
+    HIE.IdeState(..)
   , HIE.IdeGhcM
   , HIE.runIdeGhcM
   , HIE.runActionWithContext
@@ -46,7 +40,7 @@ module Haskell.Ide.Engine.PluginApi
   , HIE.iterT
   , HIE.LiftsToGhc(..)
   , HIE.HasGhcModuleCache(..)
-  , HIE.cabalModuleGraphs
+  -- , HIE.cabalModuleGraphs
   , HIE.makeRevRedirMapFunc
 
   -- * Using the HIE module cache etc
@@ -72,7 +66,6 @@ module Haskell.Ide.Engine.PluginApi
 
 
 
-import qualified GhcProject.Types                    as GP
 import qualified Haskell.Ide.Engine.Ghc              as HIE
 import qualified Haskell.Ide.Engine.GhcModuleCache   as HIE (CachedInfo(..),HasGhcModuleCache(..),emptyModuleCache)
 import qualified Haskell.Ide.Engine.ModuleCache      as HIE (ifCachedModule,runActionWithContext )

diff --git a/hie-plugin-api/hie-plugin-api.cabal b/hie-plugin-api/hie-plugin-api.cabal
@@ -50,7 +50,6 @@ library
                      , free
                      , ghc
                      , hie-bios >= 0.3.2 && < 0.4.0
-                     , ghc-project-types >= 5.9.0.0
                      , cabal-helper
                      , haskell-lsp == 0.19.*
                      , hslogger

diff --git a/stack-8.4.2.yaml b/stack-8.4.2.yaml
@@ -6,7 +6,6 @@ packages:
 extra-deps:
 # - ./submodules/HaRe
 - ./submodules/cabal-helper
-- ./submodules/ghc-mod/ghc-project-types
 
 - brittany-0.12.1.0
 - base-compat-0.9.3

diff --git a/stack-8.4.3.yaml b/stack-8.4.3.yaml
@@ -6,7 +6,6 @@ packages:
 extra-deps:
 # - ./submodules/HaRe
 - ./submodules/cabal-helper
-- ./submodules/ghc-mod/ghc-project-types
 
 - base-compat-0.9.3
 - brittany-0.12.1.0

diff --git a/stack-8.4.4.yaml b/stack-8.4.4.yaml
@@ -6,7 +6,6 @@ packages:
 extra-deps:
 # - ./submodules/HaRe
 - ./submodules/cabal-helper
-- ./submodules/ghc-mod/ghc-project-types
 
 - brittany-0.12.1.0
 - bytestring-trie-0.2.5.0

diff --git a/stack-8.6.1.yaml b/stack-8.6.1.yaml
@@ -6,7 +6,6 @@ packages:
 extra-deps:
 # - ./submodules/HaRe
 - ./submodules/cabal-helper
-- ./submodules/ghc-mod/ghc-project-types
 
 - apply-refact-0.6.0.0
 - brittany-0.12.1.0

diff --git a/stack-8.6.2.yaml b/stack-8.6.2.yaml
@@ -6,7 +6,6 @@ packages:
 extra-deps:
 # - ./submodules/HaRe
 - ./submodules/cabal-helper
-- ./submodules/ghc-mod/ghc-project-types
 
 - brittany-0.12.1.0
 - butcher-1.3.2.3

diff --git a/stack-8.6.3.yaml b/stack-8.6.3.yaml
@@ -6,7 +6,6 @@ packages:
 extra-deps:
 # - ./submodules/HaRe
 - ./submodules/cabal-helper
-- ./submodules/ghc-mod/ghc-project-types
 
 - brittany-0.12.1.0
 - bytestring-trie-0.2.5.0

diff --git a/stack-8.6.4.yaml b/stack-8.6.4.yaml
@@ -6,7 +6,6 @@ packages:
 extra-deps:
 # - ./submodules/HaRe
 - ./submodules/cabal-helper
-- ./submodules/ghc-mod/ghc-project-types
 
 - brittany-0.12.1.0
 - butcher-1.3.2.1

diff --git a/stack-8.6.5.yaml b/stack-8.6.5.yaml
@@ -6,7 +6,6 @@ packages:
 extra-deps:
 # - ./submodules/HaRe
 - ./submodules/cabal-helper
-- ./submodules/ghc-mod/ghc-project-types
 
 - ansi-terminal-0.8.2
 - ansi-wl-pprint-0.6.8.2