Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

migrate ghc-project-types into the haskell-ide-engine repo #1486

Closed
alanz opened this issue Dec 21, 2019 · 3 comments · Fixed by #1487
Closed

migrate ghc-project-types into the haskell-ide-engine repo #1486

alanz opened this issue Dec 21, 2019 · 3 comments · Fixed by #1487
Assignees
@alanz
Labels
type: discussion - decision needed

Comments

@alanz
Copy link
Collaborator

alanz commented Dec 21, 2019

As a sub-package.
@alanz alanz self-assigned this Dec 21, 2019
@alanz
Copy link
Collaborator Author

alanz commented Dec 21, 2019

cc @DanielG

@alanz
Copy link
Collaborator Author

alanz commented Dec 21, 2019

And it has a dependency on cabal-helper, it may be simplest to wait for that to appear on hackage.
I will copy it from the current submodule (fendor/ghc-mod@7757a14), and add as contributors all who show up in git blame for it, and @DanielG .

@alanz
Copy link
Collaborator Author

alanz commented Dec 21, 2019

And looking closely into the hie code, this module is only used for cabalModuleGraphs. Which is only used by HaRe, and due for a complete rework in the near future.

So perhaps the best path is to remove this completely, including the cabalModuleGraphs function, and put it back when we have a solution that makes sense.

FWIW, the original motivation for the cabal-helper wrapper types is to provide a stable API to programming against multiple cabal-versions, each of which changed the underlying data structures quite a bit.

I am not sure how much of a problem that is now, as we are supporting a narrower range of cabal, and the data structure churn is not as extreme. ?

alanz added a commit to alanz/haskell-ide-engine that referenced this issue Dec 21, 2019
@alanz
Remove ghc-project-types
738a019 
They are only used for the GHC module graph, which is currently not
generated in any useful way, so not used.

Closes haskell#1486
@alanz alanz mentioned this issue Dec 21, 2019
Merged
@alanz alanz closed this as completed in c4b014e Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alanz alanz

Labels
type: discussion - decision needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ghc-project-types alanz/haskell-ide-engine
1 participant
@alanz