UI: File API compat for IE #4376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| event.preventDefault(); | ||
| let file = this.get('fileLike'); | ||
| //lol whyyyy | ||
| window.navigator.msSaveOrOpenBlob(file, file.name); |
There was a problem hiding this comment.
Wow, this is annoying. Makes it harder to pretend that browsers are all the same.
It would be nice to hide all this msSaveOrOpenBlob stuff in some polyfill rather than in this component, but if it's only going to be used here, I guess it's not so bad.
There was a problem hiding this comment.
Yeah @johncowen mentioned https://github.com/eligrey/FileSaver.js/ which may be worth looking at if this gives us any other issues. I think for now since it's just in this component we'll try this for now.
DingoEatingFuzz
approved these changes
Apr 17, 2018
joshuaogle
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11 / Edge both don't seem to have a
Fileconstructor, so this detects the MS-specific API for saving Blobs, and will use it instead of using the File constructor to add download links to the UI.Before: it'd error out the rendering on the Show page leaving a blank textarea.
After:
Manually tested in IE11 Win7 (Note: we need to get cross-browser testing set up and getting the UI tests up and running in CI in general).