ui: glimmerize download button component #18292
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| extension: 'txt', | ||
| stringify: false, | ||
| }); | ||
| // TODO refactor and call service instead |
There was a problem hiding this comment.
Would this be the DownloadCsvService?
There was a problem hiding this comment.
Yep! Chelsea is refactoring the service now to be more general. I'll then update this action to use the service when I use this component to implement downloading a generated PKI key
| @action | ||
| handleDownload() { | ||
| const { document, URL } = window; | ||
| const downloadElement = document.createElement('a'); | ||
| downloadElement.download = this.filename; | ||
| downloadElement.href = URL.createObjectURL(this.content); | ||
| document.body.appendChild(downloadElement); | ||
| downloadElement.click(); | ||
| URL.revokeObjectURL(downloadElement.href); | ||
| downloadElement.remove(); | ||
| } |
There was a problem hiding this comment.
Quite a bit of code was refactored in this component beyond glimmerizing but it looks more straightforward and I pulled down the branch and downloads work as expected so it looks good to me!
There was a problem hiding this comment.
Thank you for testing locally! 🎉
|
One follow up, it might be nice to have some test coverage for this component. |
Yes! I started writing tests and then decided to wait until utilizing the service. If the service doesn't have enough test coverage then I'll fill that out. |
* initial glimmerization, delete toolbar-download-button component * remove extra line * cleanup component file * add data getter * delete toolbar download button component * add jsdoc to component * move class att directly to component, remove arg * remove content getter
Glimmerizes the
DownloadButtoncomponent and removesToolbarDownloadButtonThis PR also removes checking for
window.navigator.msSaveOrOpenBlobadded by #4376 because IE and Edge didn't like the File constructor. Edge added support forFile APIin 2020 so we no longer need this conditional! 🎉(P.s. we no longer support IE)
class="toolbar-link"class="button is-ghost"