Backport 1.17.x: add allow_empty_principals to ssh engine (fixes failing test) #28493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
changed the title
|
Build Results: |
hellobontempo
added
backport/ent/1.15.x+ent
backport/ent/1.16.x+ent
|
CI Results: |
hellobontempo
commented
Sep 24, 2024
| @codemirrorUpdated={{action "codemirrorUpdated" attr.name}} | ||
| /> | ||
| {{/each}} | ||
| {{#let (find-by "name" "publicKey" this.model.attrs) as |attr|}} |
hellobontempo
commented
Sep 24, 2024
| @codemirrorUpdated={{action "codemirrorUpdated" attr.name}} | ||
| /> | ||
| {{/each}} | ||
| {{#let (find-by "name" "publicKey" this.model.attrs) as |attr|}} |
hellobontempo
commented
Sep 24, 2024
| @@ -122,6 +123,10 @@ export default Model.extend({ | |||
| helpText: | |||
| 'Specifies if host certificates that are requested are allowed to be subdomains of those listed in Allowed Domains', | |||
| }), | |||
| allowEmptyPrincipals: attr('boolean', { | |||
Monkeychip
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #28484
#28466 Added allow_empty_principals to the ssh engine. Though it's recommended to keep this value false we've added for parity with the backend. Also, an acceptance test was failing because a valid_principals was not provided and is now required.
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+entlabels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.xlabel, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.