Make reception of an empty valid principals configurable based on a role flag. #28466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ole flag. Adds allow_empty_principals, which if true allows valid_principals on credential generation calls to be empty.
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
sgmiller
added
backport/ent/1.15.x+ent
backport/ent/1.16.x+ent
stevendpclark
approved these changes
Sep 23, 2024
victorr
approved these changes
Sep 23, 2024
| @@ -170,7 +170,9 @@ This endpoint creates or updates a named role. | |||
|
|
|||
| ~> **Note**: In FIPS 140-2 mode, the following algorithms are not certified | |||
| and thus should not be used: `ed25519`. | |||
|
|
|||
| - `allow_empty_principals` `(bool: false)` - Allow signing certificates with | |||
There was a problem hiding this comment.
I am not sure if the absence of the empty line matters or not. The Vercel step was skipped by the PR build, so I couldn't verify it.
sgmiller
added
backport/ent/1.16.x+ent
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds allow_empty_principals, which if true allows valid_principals on credential generation calls
to be empty.
Description
What does this PR do?
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+entlabels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.xlabel, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.