Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport UI: remove renew self call after login #28211

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Backport UI: remove renew self call after login #28211

merged 2 commits into from
Aug 29, 2024

Conversation

hashishaw
Copy link
Contributor

Description

Backport of #28204

@hashishaw
UI: remove renew self call after login (#28204)
a785663 
* check for renewAfterEpoch before comparing it

* add test coverage for regression

* add comment. Fixes VAULT-4630

* throw error

* add changelog
@hashishaw hashishaw added the ui label Aug 28, 2024
@hashishaw hashishaw added this to the 1.17.5 milestone Aug 28, 2024
@hashishaw hashishaw requested review from a team as code owners August 28, 2024 16:57
@hashishaw hashishaw changed the base branch from main to release/1.17.x August 28, 2024 17:00
@hashishaw hashishaw enabled auto-merge (squash) August 28, 2024 17:03
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 29, 2024
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw merged commit d2d7958 into release/1.17.x Aug 29, 2024
24 checks passed
@hashishaw hashishaw deleted the ui/backport-pr-28204-1.17.x/renew-self branch August 29, 2024 14:11
ryancragun added a commit that referenced this pull request Aug 29, 2024
@ryancragun
Revert "UI: remove renew self call after login (#28204) (#28211)"
85b49d6 
This reverts commit d2d7958.
ryancragun added a commit that referenced this pull request Aug 29, 2024
@ryancragun
Revert "UI: remove renew self call after login (#28204) (#28211)"
de1e950 
This reverts commit d2d7958.
ryancragun added a commit that referenced this pull request Aug 29, 2024
@hc-github-team-secure-vault-core @ryancragun
Prepare for 1.17.4 release (#28220)
1c8d1ad 
* backport of commit 78e1cce

* Revert "backport of commit a5262e0 (#28210)"

This reverts commit ff2e104.

* Revert "UI: remove renew self call after login (#28204) (#28211)"

This reverts commit d2d7958.

---------

Co-authored-by: Ryan Cragun <[email protected]>
ryancragun pushed a commit that referenced this pull request Aug 29, 2024
@hashishaw @ryancragun
UI: remove renew self call after login (#28204) (#28211)
774515f 
* check for renewAfterEpoch before comparing it

* add test coverage for regression

* add comment. Fixes VAULT-4630

* throw error

* add changelog
ryancragun added a commit that referenced this pull request Aug 29, 2024
@ryancragun @VioletHynes @hashishaw
Redo reverted 1.17.4 prep changes (#28221)
0cf0ad7 
* backport of commit a5262e0 (#28210)

Co-authored-by: Violet Hynes <[email protected]>

* UI: remove renew self call after login (#28204) (#28211)

* check for renewAfterEpoch before comparing it

* add test coverage for regression

* add comment. Fixes VAULT-4630

* throw error

* add changelog

---------

Co-authored-by: Violet Hynes <[email protected]>
Co-authored-by: Chelsea Shaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.17.5
Development

Successfully merging this pull request may close these issues.
2 participants
@hashishaw @Monkeychip