-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Environment Variables From Kubernetes Downward API #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR! Please can you add a changelog note in the unreleased section?
Improvements:
- Add
NAMESPACE
,HOST_IP
, andPOD_IP
environment variables to Agent container using downward API GH-486
Thanks for taking a look, @tomhjp. I added the section to the CHANGELOG. 😊 |
Thank you! |
@tomhjp Do you have any insight into when the next release will get cut? |
Sorry for the delay - it went out earlier this week :) |
😂 |
Haha sorry 😂 I thought I was commenting on a vault-helm issue for some reason. I'll get something penned in for the next sprint. |
@tomhjp was this addressed & shipped in vault-k8s ? |
Use the Kubernetes downward API to expose useful runtime information to the Vault Agent container through environment variables.
This PR adds the following environment variables:
NAMESPACE
(technically, this duplicates feature: Add NAMESPACE (from downward API) to list of environment vars #164, but with working tests)HOST_IP
POD_IP