Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Environment Variables From Kubernetes Downward API #486

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

mbillow
Copy link
Contributor

@mbillow mbillow commented Jun 12, 2023

Use the Kubernetes downward API to expose useful runtime information to the Vault Agent container through environment variables.

This PR adds the following environment variables:

Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR! Please can you add a changelog note in the unreleased section?

Improvements:

  • Add NAMESPACE, HOST_IP, and POD_IP environment variables to Agent container using downward API GH-486

@mbillow
Copy link
Contributor Author

mbillow commented Jun 14, 2023

LGTM, thanks for the PR! Please can you add a changelog note in the unreleased section?

Thanks for taking a look, @tomhjp. I added the section to the CHANGELOG. 😊

@tomhjp tomhjp merged commit 6433f46 into hashicorp:main Jun 14, 2023
@tomhjp
Copy link
Contributor

tomhjp commented Jun 14, 2023

Thank you!

@mbillow
Copy link
Contributor Author

mbillow commented Jun 20, 2023

@tomhjp Do you have any insight into when the next release will get cut?

@tomhjp
Copy link
Contributor

tomhjp commented Jun 28, 2023

Sorry for the delay - it went out earlier this week :)

@mbillow mbillow deleted the dwapi-env-vars branch June 28, 2023 23:01
@mbillow
Copy link
Contributor Author

mbillow commented Jun 28, 2023

Last pushed 3 months ago

e02e5ffb5f980cd8262cf7f0ae00a4a9_press-x-to-doubt-memes-memesuper-la-noire-doubt-meme_419-238

😂

@tomhjp
Copy link
Contributor

tomhjp commented Jun 29, 2023

Haha sorry 😂 I thought I was commenting on a vault-helm issue for some reason. I'll get something penned in for the next sprint.

@nicolaka
Copy link

nicolaka commented Aug 3, 2023

@tomhjp was this addressed & shipped in vault-k8s ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants