feature: Add NAMESPACE (from downward API) to list of environment vars

[cyrus-mc]

For the init and sidecar, add NAMESPACE as an environment variable (obtained from downward API).

[cyrus-mc]

In my specific case the namespace is used to denote the environment and this is useful information to have when writing templates.

Outside of my specific use case I think it is just good practice to include this information in all PODs.

[jasonodonnell]

Hi @cyrus-mc, thanks for the PR!

I see a unit test failing due to the new environment variable:

[~] make test
go test -race ./...
?   	github.com/hashicorp/vault-k8s	[no test files]
ok  	github.com/hashicorp/vault-k8s/agent-inject	2.685s
--- FAIL: TestContainerSidecar (0.00s)
    container_sidecar_test.go:104: wrong number of env vars, got 3, should have been 2
    container_sidecar_test.go:116: env name wrong, should have been VAULT_CONFIG, got NAMESPACE
    container_sidecar_test.go:120: env value empty, it shouldn't be
--- FAIL: TestContainerSidecarConfigMap (0.00s)
    container_sidecar_test.go:254: wrong number of env vars, got 2, should have been 1
FAIL
FAIL	github.com/hashicorp/vault-k8s/agent-inject/agent	2.742s
ok  	github.com/hashicorp/vault-k8s/helper/cert	6.732s
ok  	github.com/hashicorp/vault-k8s/subcommand/injector	1.997s
?   	github.com/hashicorp/vault-k8s/subcommand/version	[no test files]
?   	github.com/hashicorp/vault-k8s/version	[no test files]
FAIL
make: *** [unit-test] Error 1

Would you mind updating this test?

[jasonodonnell]

Bump @cyrus-mc

[hashicorp-cla]

All committers have signed the CLA.

[tomhjp]

Thanks for the PR! Looks like #486 got merged and has this one covered now.