Allow the route termination to be customized #671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This covers, in part, issue hashicorp#490. Namely, the route currently hardcodes the termination mode to "passhtrough". Let's parametrize this so a user can customize it. The use-case here being that we can deploy the vault in http mode and expose it via https externally and by choosing 'edge' as the termination type we let the TLS be taken care of by the route object. The default remains 'passthrough' in order to not disrupt any existing setup.
|
|
tvoran
added
enhancement
|
Thanks for the patch! I'm thinking we might as well allow users to set the whole |
|
Thanks Theron! Absolutely. #396 covers more, so let's go for that one I'll close this one out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers, in part, issue #490. Namely, the route currently hardcodes
the termination mode to "passhtrough". Let's parametrize this so a user
can customize it. The use-case here being that we can deploy the vault
in http mode and expose it via https externally and by choosing 'edge'
as the termination type we let the TLS be taken care of by the route
object.
The default remains 'passthrough' in order to not disrupt any existing
setup.