-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all secret types #63
Conversation
if err != nil { | ||
return "", err | ||
func generateRequest(client *api.Client, secret config.Secret) (*api.Request, error) { | ||
secretPath := ensureV1Prefix(secret.SecretPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if splitting on /
would be better and checking what the first value is. Then we can prepend the API version cleanly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a little play with this idea but personally found the logic both harder to follow and make robust, but perhaps I don't fully understand your idea. If you think this could simplify it, do you have a little code sample?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things but looks great to me!
Thanks for the review - as mentioned I'm deferring addressing a few of these comments into the next PR as it's already open and based on this branch. |
Adds support for all secret engines via updated config options in SecretProviderClass e.g.:
These config updates make it a breaking change for existing SecretProviderClasses, and is one of two breaking changes that are planned for the next release - the other being that we will auth to Vault as the requesting pod. Things should then be more stable after that.
As part of the updated config/support for all secret engines, this PR:
secretKey
Other small additions:
hashicorp.jfrog.io/docker
images where possiblevault-helm
chart tov0.9.1
to pull in dev mode fixYou may want to review the
provider.bats
diff with whitespace off, as I corrected some inconsistent indentation there.