Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove automatic addition of data to the path with using KV2 secrets engines #35

Closed
burtlo opened this issue Mar 25, 2020 · 1 comment
Closed

Remove automatic addition of data to the path with using KV2 secrets engines #35

burtlo opened this issue Mar 25, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone
0.0.8

Comments

@burtlo
Copy link

burtlo commented Mar 25, 2020

When defining the objectPath for the SecretProviderClass I expected that a KV2 secret path would need the entire path specified /secret/data/database/config versus what is supported /secret/database/config. I saw that the the provider detects the secret engine type and automatically adds data. This is inconsistent with the behavior of how the Vault Helm chart annotations work.
@tomhjp
Copy link
Contributor

tomhjp commented Feb 9, 2021

Addressed in #63.

@tomhjp tomhjp added the enhancement New feature or request label Feb 9, 2021
@tomhjp tomhjp mentioned this issue Feb 9, 2021
Closed
@tomhjp tomhjp added this to the 0.0.8 milestone Feb 9, 2021
@tomhjp tomhjp closed this as completed Feb 19, 2021
@tomhjp tomhjp mentioned this issue Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.0.8
Development

No branches or pull requests
2 participants
@burtlo @tomhjp