Separate loggers #26685
Merged
Separate loggers #26685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an Off level to hclog, so we can individually disable logging at various levels. Added IndependentLevels so that sublogger levels are not linked to their parents.
Codecov Report
|
jbardin
force-pushed
the
jbardin/separate-loggers
branch
from
43e1ca6 to
22f753a
Compare
Now that hclog can independently set levels on related loggers, we can separate the log levels for different subsystems in terraform. This adds the new environment variables, `TF_LOG_CORE` and `TF_LOG_PROVIDER`, which each take the same set of log level arguments, and only applies to logs from that subsystem. This means that setting `TF_LOG_CORE=level` will not show logs from providers, and `TF_LOG_PROVIDER=level` will not show logs from core. The behavior of `TF_LOG` alone does not change. While it is not necessarily needed since the default is to disable logs, there is also a new level argument of `off`, which reflects the associated level in hclog.
jbardin
force-pushed
the
jbardin/separate-loggers
branch
from
f598cbc to
eb2d443
Compare
|
This is SO AWESOME this PR needs some PR; everyone needs to see how cool it is. |
mildwonkey
approved these changes
Oct 23, 2020
This was referenced Oct 26, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both core and provider logs can be quite verbose, and it is often difficult to debug one or the other while sifting through the combination of their logs.
Here we introduce two new environment variables for more control over logging:
The existing
TF_LOGenvironment variable remains to set the global log level, but these new variables allow the viewing of the subsystem logs independently.