Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent logging structure #17367

Closed
pms1969 opened this issue Feb 16, 2018 · 4 comments
Closed

Inconsistent logging structure #17367

pms1969 opened this issue Feb 16, 2018 · 4 comments

Comments

@pms1969
Copy link

pms1969 commented Feb 16, 2018

Terraform Version

0.11.3

Debug Output

2018/02/16 08:05:03 [TRACE] root.test: eval: *terraform.EvalApplyPre
2018/02/16 08:05:03 [TRACE] root.test: eval: *terraform.EvalApply
2018/02/16 08:05:03 [DEBUG] apply: aws_route53_record.apiserver: executing Apply
2018-02-16T08:05:03.717Z [DEBUG] plugin.terraform-provider-aws_v1.9.0_x4: 2018/02/16 08:05:03 [DEBUG] [aws-sdk-go] DEBUG: Request route53/GetHostedZone Details:
2018-02-16T08:05:03.717Z [DEBUG] plugin.terraform-provider-aws_v1.9.0_x4: ---[ REQUEST POST-SIGN ]-----------------------------

Expected Behavior

I'd expect all the logs to begin with the Timezone attributed date/time:

2018-02-16T08:05:03.717Z [DEBUG] apply: aws_route53_record.apiserver: executing Apply
2018-02-16T08:05:03.717Z [TRACE] another log message
2018-02-16T08:05:03.717Z [INFO]  and another log message

Steps to Reproduce

Pick any terraform template and apply it.

  1. terraform init
  2. terraform apply

I know it's bound to be low priority, but it would be handy to have consistent logging output, from a cognitive point of view, and from a log parsing one as well.

@apparentlymart
Copy link
Contributor

Hi @pms1969! Sorry the logs are not as helpful as they could be.

Right now there are many different subsystems all writing to the logs, and indeed some inconsistency between them. Improving the log consistency is something we would like to do, but to be totally transparent with you it is not likely to be a high priority for a while yet, since there are many other things that we'll need to work on first.

@pms1969
Copy link
Author

pms1969 commented Feb 17, 2018

Completely understand.

@jbardin
Copy link
Member

jbardin commented Oct 26, 2020

Core is now using hclog throughout, and can better integrate with the logging from go-plugin.

Closed by #26632, #26665, #26685 and #26694

@jbardin jbardin closed this as completed Oct 26, 2020
@ghost
Copy link

ghost commented Nov 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants