Changed zone name to be read correctly in google_compute_disk's detach logic

[rileykarson]

We don't support attaching/detaching disks post-create yet in instances, so the instance the disk was previously attached to will no longer be able to be Read as a result of this; we may not want to merge for that reason.

Right now, if we end up in the Delete for an attached disk, we error out because the zone is being set to a zone url and not a zone name in the detach request.

Fixes #112

[danawillow]

This looks fine, but will it alone fix #112? It'll fix the detach error I assume, but it looks like the bigger issue is the fact the disk is trying to be recreated (which has to do with the snapshot url vs name)

[paddycarver]

I think #238 is the fix for snapshot URL v name.

[rileykarson]

^Yup, #238 tracks the snapshot url vs name, and #112 is disks not being able to detach themselves. The issue that #238 fixes tends to trigger #112, though; it's tracked by #218

[danawillow]

Got it, thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!