Google compute engine instance and disk referencing error

[hashibot]

This issue was originally opened by @nodesocket as hashicorp/terraform#15181. It was migrated here as part of the provider split. The original body of the issue is below.

---

Think I discovered a bug using google_compute_disk and google_compute_instance referencing resources.

Create a disk using a resource block like:

resource "google_compute_disk" "blog" {
    name  = "blog"
    type  = "pd-ssd"
    zone  = "us-west1-a"
    snapshot = "some-snapshot-here"
    size = 10
}

Then create an instance referencing the above disk:

resource "google_compute_instance" "blog" {
    name = "blog"
    machine_type = "f1-micro"
    zone = "${google_compute_disk.blog.zone}"

    tags = []

    disk {
        disk = "${google_compute_disk.blog.name}"
        auto_delete = true
    }

    network_interface {
        network = "default"
        access_config {
            # ephemeral external ip address
        }
    }

    metadata {
    }

    service_account {
        scopes = ["https://www.googleapis.com/auth/servicecontrol",
                  "https://www.googleapis.com/auth/service.management.readonly",
                  "https://www.googleapis.com/auth/logging.write",
                  "https://www.googleapis.com/auth/monitoring.write",
                  "https://www.googleapis.com/auth/trace.append",
                  "https://www.googleapis.com/auth/devstorage.read_only",
                  "https://www.googleapis.com/auth/cloud.useraccounts.readonly"]
    }

    scheduling {
        preemptible = false
        on_host_maintenance = "MIGRATE"
        automatic_restart = true
    }
}

After the apply finishes, run apply again. You will see the following error:

Error applying plan:

1 error(s) occurred:

* google_compute_disk.blog (destroy): 1 error(s) occurred:

* google_compute_disk.blog: Error detaching disk persistent-disk-0 from instance project-id-here/https://www.googleapis.com/compute/v1/projects/project-id-here/zones/us-west1-a/blog: googleapi: Error 400: Invalid value 'https://www.googleapis.com/compute/v1/projects/project-id-here/zones/us-west1-a'. Values must match the following regular expression: '[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?', invalidParameter

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

[nodesocket]

Bump of this please. The specific error seems to be:

Error detaching disk persistent-disk-0 from instance project-id-here/https://www.googleapis.com/compute/v1/projects/project-id-here/zones/us-west1-a/blog: googleapi: Error 400: Invalid value 'https://www.googleapis.com/compute/v1/projects/project-id-here/zones/us-west1-a'. Values must match the following regular expression: '[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?', invalidParameter

[danawillow]

Hey @nodesocket, sorry you're having issues. I'm actually doing a big rework of the disk attaching process so I'm not going to be able to get to this specific issue right away, but it should be resolved reasonably soon as a result of the other work!

[nodesocket]

Great. Is this specific to creating a disk from a snapshot or does this bug also apply to creating disks via an image and associating with a VM instance?

[danawillow]

My work is focusing on the latter.

[nodesocket]

Ok, well I need both cases to work 😸 .

Create disk from snapshot:

resource "google_compute_disk" "blog" {
    name  = "blog"
    type  = "pd-ssd"
    zone  = "us-west1-a"
    snapshot = "some-snapshot-here"
    size = 10
}

Create disk from image:

resource "google_compute_disk" "blog" {
    name  = "blog"
    type  = "pd-ssd"
    zone  = "us-west1-a"
    image = "some-image-here"
    size = 10
}

---

disk {
    disk = "${google_compute_disk.blog.name}"
    auto_delete = true
}

[nodesocket]

This seems to actually still be a bug.

iMac ➜  terraform git:(master) ✗ terraform apply
Error applying plan:

1 error(s) occurred:

* google_compute_disk.blog (destroy): 1 error(s) occurred:

* google_compute_disk.blog: Error detaching disk persistent-disk-0 from instance my-project/https://www.googleapis.com/compute/v1/projects/my-project/zones/us-west1-a/blog: googleapi: Error 400: Invalid value 'https://www.googleapis.com/compute/v1/projects/my-project/zones/us-west1-a'. Values must match the following regular expression: '[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?', invalidParameter

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

-/+ google_compute_disk.blog (new resource required)
      disk_encryption_key_sha256: "" => "<computed>"
      name:                       "blog" => "blog"
      self_link:                  "https://www.googleapis.com/compute/v1/projects/my-project/zones/us-west1-a/disks/blog" => "<computed>"
      size:                       "10" => "10"
      snapshot:                   "https://www.googleapis.com/compute/v1/projects/my-project/global/snapshots/blog-2017-07-12-1" => "blog-2017-07-12-1" (forces new resource)
      type:                       "pd-ssd" => "pd-ssd"
      users.#:                    "1" => "<computed>"
      zone:                       "us-west1-a" => "us-west1-a"

[rileykarson]

The disk should be successfully detached with #320; I just wanted to note that this doesn't mean that attaching and detaching will work, and that deleting a disk means it will be removed completely from the instance. The delete operation will just succeed now, instead of failing unintentionally.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!